[feat] Add unsubscribe link to email notifications #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements and closes #132. --------- Co-authored-by: Federico Capoano <[email protected]> Co-authored-by: Gagan Deep <[email protected]>
- Updated the `NotificationSettingSerializer` to also include `organization_name`. - New endpoint `/api/user-setting/organization/<uuid:organization_id>/` to allow changes toggling of email/web notification settings of a particular org with just a single API call.
…ail and web checkboxes
pandafy
requested changes
Sep 6, 2024
openwisp_notifications/static/openwisp-notifications/js/unsubscribe.js
Outdated
Show resolved
Hide resolved
openwisp_notifications/templates/openwisp_notifications/unsubscribe.html
Show resolved
Hide resolved
- Removed preference api endpoint and just used the `/user-setting` endpoint. - Fixed some bugs in preference page for handling few cases like enabling of global web setting when any one email setting is turned on (toggles it off). - Handled validation of only one global setting per user in model level.
nemesifier
requested changes
Sep 25, 2024
pandafy
force-pushed
the
notification-preferences
branch
from
bdadba4 to
0feb0d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #256
FYR, Please note that this feature depends on PR #290 to manage global email notification preferences, which is not implemented in this PR. Currently, the user's first notification will be treated as their global email notification preference.
Regarding the email token generated: